-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peform single push on upload in case of multiple releases #314
Conversation
8157b4c
to
5fd540c
Compare
@davidkarlsen can you have a look at this pr? |
I just realized that my PR is a duplicate of this one, and this one is better as it fixes the tests. #336 Can we have someone take a look at this PR please ? |
does anyone can provide some manual tests on this? @amalgamm @gaelgatelement and show the logs and maybe the ci job |
I'm using this fork in our own CI runs : https://github.com/vector-im/ess-starter-edition-core/actions/runs/6624187779 |
thanks @gaelgatelement |
tested on my side and seems to work fine :) |
Hi! I just run into the issue this PR fixes, it'd be cool to have it merged! |
Signed-off-by: Ivan Panteleev <ispanteleev@gmail.com> Signed-off-by: amalgamm <ispanteleev@gmail.com>
85d7dad
to
8ea3170
Compare
@cpanato I think I fixed the lint. Sorry it took so long |
Did you test the case with |
I didn't but I think this case is covered by tests |
please merge |
Any way to get this merged? @cpanato |
Sorry to tag again @cpanato but I'm running into the described issue as well and am hoping to see this merged. Thank you! |
I did a test using the latest chart-release and two chart updates and i see one push: https://github.com/cpanato/testing-ci-providers/actions/runs/9764682879/job/26953586398 Is this PR trying to update as well? If so, are we good, or am I missing something else? |
Bump. |
Hello, does this PR have any chance to get merged anytime ?? |
Adding my voice to this - would really like to see this get merged so that our Private GH Page Helm Chart "repo" can function properly with multiple charts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
will be good if someone uses the chart-releaser from main and confirm this is working |
is there a prerelease tag or similar we can use to download? I don't see a build associated with main at this time. |
we dont build and push main branch, but if that is the community want we can setup that |
It's more of an ease of testing ask. Without a prerelease tag I have to clone, build, put into a custom container, then modify my existing pipelines to no longer download but instead leverage the installed version. In contrast I can just change the tag and test it if it were pre-tagged. I'm assuming you branch per release so you can cherry pick and hotfix then? I honestly didn't look at your branching strategy. At anyrate Ill build locally and give it a test, just figured id take the shortcut if it was available |
Quick update: quick tests are promising, but most my pipelines use chart releaser action which has no way to use an existing version of cr (checking the code it always downloads). I would have to replace the action with a custom run step which then obfuscates testing (is cr having a problem or do I suck writing my own GHA steps?) If you are capable of creating a pre-release version (i see its been done in the past) I can give it a more "real world" test, otherwise I can only do simple mocks. |
This is something I need as well. Has there been any progress on this? |
I would love to have some better insight on the release process in general. From what I can tell, this has been merged sense October, but going on 2 months later we still don`t have a release. What is the process for this and how can I help it along? |
@Justin-DynamicD needs more time as this is on my free time, also if you want to help, please review the PRs, triage issues, and submit any improvements that you might want to see release is out: https://github.com/helm/chart-releaser/releases/tag/v1.7.0 will update the action in a few days |
thank you very much for the update! I was going to report that I have been running off the main branch all week without issue so the merge seems solid, but Ill happily switch to 1.7.0 |
Resolves the problem mentioned in this PR
Lets say you want to upload more than one release and place it near the index file. After the first push your second push will be rejected with an error "Updates were rejected because a pushed branch tip is behind its remote". So either you need to pull changes before push another release or push all releases once in the end of upload action.
In case of pulling changes and pushing every release separately you'll face github will launch as many "pages build and deployment" actions as there are new releases you want to upload. All except one will be canceled, but the list of actions will look like a mess.
So the most efficient way is to make single push in the end of upload.